Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clone http request for ws transport #227

Merged
merged 2 commits into from
Jan 10, 2024
Merged

Clone http request for ws transport #227

merged 2 commits into from
Jan 10, 2024

Conversation

Totodore
Copy link
Owner

Motivation

Before http 1.0 the Parts struct was not clonable because extensions were not. Because it is now possible, we can now clone the whole Parts sruct rather than rebuilding it for the ws transport.
Therefore it is now possible to retrieve Extensions related to the initialized request.

Solution

Use parts.clone() rather than rebuilding an entire Request struct and ommitting the extensions field.

@Totodore Totodore added enhancement New feature or request engineio-v3 It is only about the version 3 of the engine.io protocol engineio-v4 It is only about the version 4 of the engine.io protocol labels Jan 10, 2024
@Totodore Totodore enabled auto-merge (squash) January 10, 2024 13:21
@tausifcreates
Copy link
Contributor

This is revolutionary!

@Totodore Totodore merged commit f4c12bb into main Jan 10, 2024
12 checks passed
@Totodore Totodore deleted the feat-clone-req branch January 10, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engineio-v3 It is only about the version 3 of the engine.io protocol engineio-v4 It is only about the version 4 of the engine.io protocol enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants