fix(socketio/client): connect timeout panic under heavy traffic #252
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Under heavy traffic, some desynchronisation between events might happen and then lead to panic with the connect timeout mechanism.
If a ns connect message is received, we stop the connect timeout task. But if the connect timeout task has been triggerred in the meantime the
Receiver
is dropped and theSender
will panic because we unwrap the send errortx.send(()).unwrap();
.Solution
Discard the error like that
tx.send(()).ok();