-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(socketio/extensions): rework extensions and add an Extension
decorator and an HttpExtension
decorator
#309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Totodore
added
bug
Something isn't working
socketio-v4
It is only about the version 4 of the socket.io protocol
socketio-v5
It is only about the version 5 of the socket.io protocol
labels
Apr 20, 2024
This comment has been minimized.
This comment has been minimized.
Totodore
changed the title
Feat: rework extensions and add an
feat(socketio/extensions): rework extensions and add an Apr 20, 2024
Extension
decorator and an HttpExtension
decoratorExtension
decorator and an HttpExtension
decorator
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Bencher
Click to view all benchmark results
Bencher - Continuous Benchmarking View Public Perf Page Docs | Repo | Chat | Help |
Totodore
force-pushed
the
feat-extensions-rework
branch
from
June 4, 2024 09:41
d5c01f7
to
334e32a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
socketio-v4
It is only about the version 4 of the socket.io protocol
socketio-v5
It is only about the version 5 of the socket.io protocol
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the
Extension
implementationRwLock<HashMap>
rather than aDashMap
for concurrent access.Clone
the returned data fromget
get_mut
fnAdd
Extension
extractor.HttpExtension
extractor that extracts from theHttpRequest
.Refactor
extract
module into submodulesTodo
Resolves issue :