handling send to socket error #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Totodore
reviewed
Jun 21, 2023
Totodore
reviewed
Jun 21, 2023
biryukovmaxim
changed the title
|
I didn't realized that returning the packet to send when there is an error implies to We could tweak the emit fn so it could directly emit Otherwise, the easiest solution would be to return an error but without the packet... What do you think @biryukovmaxim ? |
Totodore
approved these changes
Jun 22, 2023
|
Noo plz, let me 20 minutes. I will show |
|
Sorry, I'm reverting the pr 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #27
create SendError enum, BroadcastError
handle these errors
@Totodore I left todos in places where I don't know how to handle error correctly