Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing EngineIO CI configuration #47

Merged
merged 1 commit into from
Jul 2, 2023

Conversation

sleeyax
Copy link
Contributor

@sleeyax sleeyax commented Jul 2, 2023

I was just missing the build command. I assumed cargo run would already build + run the binary, not sure why it doesn't seem to work that way though. Anyways, this commit should fix it.

@sleeyax
Copy link
Contributor Author

sleeyax commented Jul 2, 2023

Note that 1 test still fails because the non-base64-encoded binary packet still isn't' implemented, as I mentioned in #24 (comment):

1) Engine.IO protocol
       message
         HTTP long-polling
           sends and receives a payload containing plain text and binary packets (binary):

      AssertionError: expected  to deeply equal 
      + expected - actual


      at Context.<anonymous> (file:///home/runner/work/socketioxide/socketioxide/engine.io-protocol/test-suite/test-suite.js:279:27)
      at processTicksAndRejections (node:internal/process/task_queues:96:5)

@Totodore Totodore merged commit c41933a into Totodore:main Jul 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants