feat(engineioxide/v3) binary encoding payload #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The query param `b64` is taken from the handshake and given to each socket (by default it false and binary support will be prefered)
Implements v3 & v4 encoder in a custom payload module with different behavior. Supports binary encoder for v3.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Totodore
changed the title
Packet length information in v3 binary encoding was directly put as u64 bytes whereas it should be one byte per digit
Add binary Content-Type with binary encoding
This reverts commit 5c5cd74.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add binary payloads support for v3.
It will fix CI and allow to fully support engine.io v3.
Steps :
closes the session upon invalid packet formatin v3benchmark decoding encoding and compare stream decoding with previous buffered implementation