feat(ui): disable variables for column names that affect the schema (#…

…2235) We'd like to schema of dataset to be predicitble. So we start disallowing dynamic column names where it could happen.
ToucanToco · Oct 18, 2024 · 353c13c · 353c13c
1 parent 61ee728
commit 353c13c
Show file tree

Hide file tree

Showing 12 changed files with 0 additions and 54 deletions.
diff --git a/ui/src/components/stepforms/AbsoluteValueStepForm.vue b/ui/src/components/stepforms/AbsoluteValueStepForm.vue
@@ -25,9 +25,6 @@
       data-path=".newColumn"
       :errors="errors"
       :warning="duplicateColumnName"
-      :available-variables="availableVariables"
-      :variable-delimiters="variableDelimiters"
-      :trusted-variable-delimiters="trustedVariableDelimiters"
     />
     <StepFormButtonbar />
   </div>

diff --git a/ui/src/components/stepforms/AddMissingDatesStepForm.vue b/ui/src/components/stepforms/AddMissingDatesStepForm.vue
@@ -13,9 +13,6 @@
       placeholder="Select a column"
       data-path=".datesColumn"
       :errors="errors"
-      :available-variables="availableVariables"
-      :variable-delimiters="variableDelimiters"
-      :trusted-variable-delimiters="trustedVariableDelimiters"
       :columnNames="columnNames"
       :selectedColumns="selectedColumns"
       @setSelectedColumns="setSelectedColumns"

diff --git a/ui/src/components/stepforms/AddTextColumnStepForm.vue b/ui/src/components/stepforms/AddTextColumnStepForm.vue
@@ -14,9 +14,6 @@
       data-path=".newColumn"
       :errors="errors"
       :warning="duplicateColumnName"
-      :available-variables="availableVariables"
-      :variable-delimiters="variableDelimiters"
-      :trusted-variable-delimiters="trustedVariableDelimiters"
     />
     <InputTextWidget
       class="textInput"

diff --git a/ui/src/components/stepforms/AggregateStepForm.vue b/ui/src/components/stepforms/AggregateStepForm.vue
@@ -15,9 +15,6 @@
       placeholder="Add columns"
       data-path=".on"
       :errors="errors"
-      :available-variables="availableVariables"
-      :variable-delimiters="variableDelimiters"
-      :trusted-variable-delimiters="trustedVariableDelimiters"
       :allowCustom="true"
     />
     <ListWidget

diff --git a/ui/src/components/stepforms/FormulaStepForm.vue b/ui/src/components/stepforms/FormulaStepForm.vue
@@ -14,9 +14,6 @@
       data-path=".newColumn"
       :errors="errors"
       :warning="duplicateColumnName"
-      :available-variables="availableVariables"
-      :variable-delimiters="variableDelimiters"
-      :trusted-variable-delimiters="trustedVariableDelimiters"
     />
     <InputTextWidget
       class="formulaInput"

diff --git a/ui/src/components/stepforms/RenameStepForm.vue b/ui/src/components/stepforms/RenameStepForm.vue
@@ -18,9 +18,6 @@
       :automatic-new-field="false"
       data-path=".toRename"
       :errors="errors"
-      :available-variables="availableVariables"
-      :variable-delimiters="variableDelimiters"
-      :trusted-variable-delimiters="trustedVariableDelimiters"
       unstyled-items
       :columnNames="columnNames"
       :selectedColumns="selectedColumns"

diff --git a/ui/src/components/stepforms/SplitStepForm.vue b/ui/src/components/stepforms/SplitStepForm.vue
@@ -13,9 +13,6 @@
       placeholder="Enter a column"
       data-path=".column"
       :errors="errors"
-      :available-variables="availableVariables"
-      :variable-delimiters="variableDelimiters"
-      :trusted-variable-delimiters="trustedVariableDelimiters"
       :columnNames="columnNames"
       :selectedColumns="selectedColumns"
       @setSelectedColumns="setSelectedColumns"

diff --git a/ui/src/components/stepforms/UnpivotStepForm.vue b/ui/src/components/stepforms/UnpivotStepForm.vue
@@ -15,9 +15,6 @@
       placeholder="Add columns to keep"
       data-path=".keep"
       :errors="errors"
-      :available-variables="availableVariables"
-      :variable-delimiters="variableDelimiters"
-      :trusted-variable-delimiters="trustedVariableDelimiters"
       :allowCustom="true"
     />
     <MultiselectWidget
@@ -29,9 +26,6 @@
       placeholder="Add columns to unpivot"
       data-path=".unpivot"
       :errors="errors"
-      :available-variables="availableVariables"
-      :variable-delimiters="variableDelimiters"
-      :trusted-variable-delimiters="trustedVariableDelimiters"
       :allowCustom="true"
     />
     <CheckboxWidget

diff --git a/ui/src/components/stepforms/WaterfallStepForm.vue b/ui/src/components/stepforms/WaterfallStepForm.vue
@@ -14,9 +14,6 @@
       data-path=".valueColumn"
       :syncWithSelectedColumn="false"
       :errors="errors"
-      :available-variables="availableVariables"
-      :variable-delimiters="variableDelimiters"
-      :trusted-variable-delimiters="trustedVariableDelimiters"
       :columnNames="columnNames"
       :selectedColumns="selectedColumns"
       @setSelectedColumns="setSelectedColumns"
@@ -96,9 +93,6 @@
       placeholder="Add columns"
       data-path=".groupby"
       :errors="errors"
-      :available-variables="availableVariables"
-      :variable-delimiters="variableDelimiters"
-      :trusted-variable-delimiters="trustedVariableDelimiters"
       :allowCustom="true"
     />
     <AutocompleteWidget

diff --git a/ui/src/components/stepforms/widgets/Aggregation.vue b/ui/src/components/stepforms/widgets/Aggregation.vue
@@ -9,9 +9,6 @@
       placeholder="Select columns"
       :data-path="`${dataPath}.columns`"
       :errors="errors"
-      :available-variables="availableVariables"
-      :variable-delimiters="variableDelimiters"
-      :trusted-variable-delimiters="trustedVariableDelimiters"
       :allowCustom="true"
     />
     <AutocompleteWidget

diff --git a/ui/src/components/stepforms/widgets/CumSum.vue b/ui/src/components/stepforms/widgets/CumSum.vue
@@ -22,9 +22,6 @@
       :data-path="`${dataPath}[1]`"
       :warning="duplicateColumnName"
       :errors="errors"
-      :available-variables="availableVariables"
-      :variable-delimiters="variableDelimiters"
-      :trusted-variable-delimiters="trustedVariableDelimiters"
     />
   </div>
 </template>

diff --git a/ui/src/components/stepforms/widgets/Rename.vue b/ui/src/components/stepforms/widgets/Rename.vue
@@ -8,9 +8,6 @@
       :syncWithSelectedColumn="false"
       :data-path="`${dataPath}[0]`"
       :errors="errors"
-      :available-variables="availableVariables"
-      :variable-delimiters="variableDelimiters"
-      :trusted-variable-delimiters="trustedVariableDelimiters"
       :columnNames="columnNames"
       :selectedColumns="selectedColumns"
       @setSelectedColumns="$emit('setSelectedColumns', $event)"
@@ -22,9 +19,6 @@
       :data-path="`${dataPath}[1]`"
       :warning="duplicateColumnName"
       :errors="errors"
-      :available-variables="availableVariables"
-      :variable-delimiters="variableDelimiters"
-      :trusted-variable-delimiters="trustedVariableDelimiters"
     />
   </div>
 </template>
@@ -58,15 +52,6 @@ export default class RenameWidget extends Vue {
   @Prop({ type: Array, default: () => [] })
   errors!: ErrorObject[];
 
-  @Prop()
-  availableVariables?: VariablesBucket;
-
-  @Prop()
-  variableDelimiters?: VariableDelimiters;
-
-  @Prop()
-  trustedVariableDelimiters?: VariableDelimiters;
-
   @Prop({ default: () => [] })
   selectedColumns!: string[];