Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(server/pypika): reverse OFFSET and LIMIT for Athena translator [TCTC-9905] #2296

Merged
merged 1 commit into from
Dec 5, 2024
Merged

fix(server/pypika): reverse OFFSET and LIMIT for Athena translator [TCTC-9905] #2296

merged 1 commit into from
Dec 5, 2024

Conversation

lukapeschke
Copy link
Contributor

…CTC-9905]

@lukapeschke
fix(server/pypika): reverse OFFSET and LIMIT for Athena translator [T…
2c1473b 
…CTC-9905]

Signed-off-by: Luka Peschke <luka.peschke@toucantoco.com>
@lukapeschke lukapeschke added bug Something isn't working need review pypika Changes concern the PyPika translator labels Dec 5, 2024
@lukapeschke lukapeschke self-assigned this Dec 5, 2024
@lukapeschke lukapeschke requested a review from a team as a code owner December 5, 2024 09:53
@lukapeschke lukapeschke requested review from Fanaen and julien-pinchelimouroux and removed request for a team December 5, 2024 09:53
@lukapeschke lukapeschke changed the title fix(server/pypika): reverse OFFSET and LIMIT for Athena translator [T… fix(server/pypika): reverse OFFSET and LIMIT for Athena translator [TCTC-9905] Dec 5, 2024
julien-pinchelimouroux
julien-pinchelimouroux approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@julien-pinchelimouroux julien-pinchelimouroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@lukapeschke lukapeschke merged commit f07fb07 into master Dec 5, 2024
3 checks passed
@lukapeschke lukapeschke deleted the fix-athena-offset-limit branch December 5, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-pinchelimouroux julien-pinchelimouroux julien-pinchelimouroux approved these changes

@Fanaen Fanaen Awaiting requested review from Fanaen Fanaen is a code owner automatically assigned from ToucanToco/build_back

Assignees

@lukapeschke lukapeschke

Labels
bug Something isn't working need review pypika Changes concern the PyPika translator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukapeschke @julien-pinchelimouroux