Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keeping sent a package during the stream for firewall hole punching #117

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

CosbyBs86
Copy link
Contributor

I added the keep alive hole punching (default 30 seconds). It is not possible to create a dedicated thread for this operation because the socket is bound in Receiver() method and it might collide with the blocking Receive operation. I added a check in the receiver loop. If the time between the last keep alive and the current time is >= with the defined timeout (30 seconds as default) a package is sent.

@CosbyBs86
Copy link
Contributor Author

@Touseefelahi here we go for the keep alive firewall hole punching.

@Touseefelahi Touseefelahi merged commit 4b52e65 into Touseefelahi:master Jul 24, 2024
1 check passed
@CosbyBs86
Copy link
Contributor Author

Thank you @Touseefelahi
Do you have any chance to make a release with all those changes and publish it as new nuget package?

@Touseefelahi
Copy link
Owner

You're welcome @CosbyBs86
If you are done with your changes then I'll do it by the end of this week

@CosbyBs86
Copy link
Contributor Author

Yes @Touseefelahi I finished all the changes. For me you can go with the new release.

@Touseefelahi
Copy link
Owner

@CosbyBs86 hey, I just updated the Nuget package. Thank you for your contribution.
Can you share your contact info, email or Whatsapp number?

@CosbyBs86
Copy link
Contributor Author

@Touseefelahi if you share your email I'll send my contacts. I don't want to publish them here ;)

@Touseefelahi
Copy link
Owner

Touseefelahi commented Jul 24, 2024

@CosbyBs86 sure, contact me at touseefelahi@ymail.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants