New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve town mapcolour retrieval #18

Merged

Goosius1 merged 3 commits into TownyAdvanced:master from Goosius1:improve_town_mapcolour_retrieval

Mar 19, 2021

Goosius1 commented Mar 18, 2021

Current code uses nation.getMapColorHexCode() to get town colours
However a new method was added recently in 0.96.7.8 - town.getMapColorHexCode().
This method is hooked up to an event, and is needed for some ahem myserterious work I am doing at the moment in siegewar.
In this PR I update the code to get the town colour using the new method
Also fixed an issue where the version checker was not working right

[x] Tested on local server
[x] Usual TownyAdvanced copyright acceptance etc.

goosius1goosius1@gmail.com added 3 commits

March 18, 2021 18:04


          Improved town map colour retrieval

4e2d053


          Fixed bug with version checking

d778c6f


          Town colour retrieval fixes

76f810b

LlmDl approved these changes

View reviewed changes

Goosius1 merged commit 81934e3 into TownyAdvanced:master

Goosius1 deleted the improve_town_mapcolour_retrieval branch

March 19, 2021 00:02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet