Added config option to enable/disable dynamic town colours #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also updated pom
Warriorrrr
approved these changes
Aug 6, 2021
Comment on lines
+563
to
+570
| //CALCULATE FILL COLOUR | ||
| if (dynamicTownColorsEnabled) { | ||
| //Here we know the server is using town colors. This takes top priority for fill | ||
| colorHexCode = town.getMapColorHexCode(); | ||
| if(!colorHexCode.isEmpty()) { | ||
| //If town has a color, use it | ||
| townFillColorInteger = Integer.parseInt(colorHexCode, 16); | ||
| } |
There was a problem hiding this comment.
The nation's map color could be used as a fallback here, in case the town has not set a map color yet
There was a problem hiding this comment.
- I considered that
- The only scenario this fallback could happen is when a server had already been using nation colours, and just upgraded the system to allow special town colours.
- In this scenario, players could be very familiar with the scheme of a single colour in each town, indicating nation allegiance.
- Assume as standard that the players & maybe staff do not read the release information on the town colour feature.
- With the indicated fallback, at first nothing would change, but they would soon see just ONE or TWO towns diverge from the familiar scheme, causing them to potentially think that a bug was happening, and causing scattered confusion.
- Without the indicated fallback, town fill instead falls back to the default dynmap colour. Thus the server will immediately see ALL towns suddenly fill red, which will be an unmistakeable signal for them to wake up and notice/discuss the new feature, which I hope will be a better experience & introduction to the feature than the previous.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION
IMPLEMENTATION
TESTING