Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove newday timer option #7509

Merged
merged 3 commits into from
Jul 28, 2024
Merged

Remove newday timer option #7509

merged 3 commits into from
Jul 28, 2024

Conversation

Warriorrrr
Copy link
Member

Description:

This feature is unlikely to be used by servers, and the folia scheduling api already replaces the need for it.

  • I have tested this pull request for defects on a server.

By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the Towny License for perpetuity.

@Warriorrrr Warriorrrr added this to the 0.100.4.0 milestone Jul 15, 2024
LlmDl
LlmDl requested changes Jul 15, 2024
View reviewed changes
Copy link
Member

@LlmDl LlmDl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the only thing that's off now is that the feedback message in /ta newday is wrong now.

I'd suggest reverting the code to how it was, and then adding another if isRunning throw "its already running" message using a new lang string.

@Warriorrrr
Copy link
Member Author

I'm not sure how needed the feedback message is, since it'll be able to handle two new days being started at the same time now

@LlmDl LlmDl merged commit 6f12d77 into master Jul 28, 2024
4 checks passed
LlmDl added a commit that referenced this pull request Jul 28, 2024
@LlmDl
- Always fire loaded metadata event, courtesy of Warrior with
015a596 
PR #7531.
  - Remove newday timer option, courtesy of Warrior with PR #7509.
  - Bump org.apache.maven.plugins:maven-surefire-plugin from 3.3.0 to
3.3.1.
  - Bump org.apache.maven.plugins:maven-javadoc-plugin from 3.7.0 to
3.8.0.
@Warriorrrr Warriorrrr deleted the feat/remove-timer-option branch September 10, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LlmDl LlmDl LlmDl requested changes

Assignees
No one assigned
Labels
enhancement Label-Command Label-TownyAdmin
Projects
None yet
Milestone
0.100.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Warriorrrr @LlmDl