Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vehicle bar taint #26

Merged
merged 2 commits into from
Dec 19, 2022
Merged

Vehicle bar taint #26

merged 2 commits into from
Dec 19, 2022

Conversation

RyadaProductions
Copy link
Collaborator

Closes #1

Summary of Changes

  1. Properly handles going into combat when trying to mount up on the Dragonflight mount.

Description

Previously it was possible to reliably taint the vehicle bar by trying to mount up and getting in combat during the 1.5 second cast of it. This should now be handled gracefully and not leave the UI in a tainted/broken state.

To test

  • Go to a patrolling mob.
  • Position yourself along its patrol.
  • Try mounting up just before you get into combat with the patrol
  • Should not throw errors and after killing the mob should place the vehicle bar in the correct position on the screen with animation.

@RyadaProductions RyadaProductions changed the base branch from stable to development December 18, 2022 20:06
@nawuko
Copy link

nawuko commented Dec 18, 2022

This is a solution, but a very bad one, calling something like this in an OnUpdate is a big no-no, the vehiclebar has code to pause animations when the combat event is fired, something with that is the root cause

@Toxicom Toxicom merged commit 9ad5b2b into development Dec 19, 2022
@Toxicom Toxicom deleted the vehicle-bar-taint branch December 19, 2022 16:19
Toxicom added a commit that referenced this pull request Mar 7, 2023
@Toxicom @Wolen
@Uncaught3xception @bagelbits @RyadaProductions @shrift
🚀 RELEASE: 6.1.6 (#45)
cac0540 
* Fixed Rune Abbreviation (#4)

* 👌 IMPROVE: Match default UI action bars (#5)

* 👌 IMPROVE: Match default UI action bars

* 🤖 TEST: Fix CI

* 9.2.7 -> 10.0 Fixes (#6)

* Fixes a lot of the errors to get it running.

* Style fix

* 🤖 TEST: Remove unused vars

* 🤖 TEST: Follow-up

* 🤖 TEST: Remove `.bak` files

* WeakAuraAnchor fix

Co-authored-by: Tomas Leonavičius <69549795+Toxicom@users.noreply.github.com>

* 👌 IMPROVE: Fuck off taints

* 📖 DOC: Prepare badge for Wolen

* 👌 IMPROVE: Disable bars 13-15

* 🐛 FIX: Update WAAnchor position

* 🤖 TEST: umm maybe fix CI

* 📖 DOC: Update changelog

* 📖 DOC: Update DF WA link

* 🐛 FIX: Fixed Rune Enchant Abbr (#7)

* 🐛 FIX: Fixed Profession Open / Close (#10)

* 🐛 FIX: Revert font outline change

* 🤖 TEST: ci fix

* 🤖 TEST: Remove unused var

* 🤖 TEST: Personal font changes

* 🐛 FIX: Wunderbar Professions, VehicleBar (#11)

* Fixed Wunderbar Professions, VehicleBar

* 🤖 TEST: Update luacheckrc

* 🐛 FIX: More Vehicle Fixes

Co-authored-by: Tomas Leonavičius <69549795+Toxicom@users.noreply.github.com>

* 📖 DOC: Clean up badges

* 🐛 FIX: Reputation bar is no longer 100% (#13)

* 📖 DOC: Ande chat badge

* #12 DataBar & professions fix

* 🤖 TEST: ci fix

* Various fixes (#14)

* 🐛 FIX: ElvUI Theme

* 🐛 FIX: Update WB Currency module

* 🐛 FIX: Update WA Anchor

* 🐛 FIX: Update BlizzardFonts

* 🐛 FIX: WB Professions updates

* 🤖 TEST: CI fix?

* Update README.md

* Update README.md

* 🤖 TEST: Disable custom buttons again

* 🐛 FIX: Clicking hearthstone works again (#15)

* 🐛 FIX: Reverted Vehiclebar Updating/Paging (#16)

* ElvUI update (#17)

* 🐛 FIX: ElvUI 13.01 changes

* 🐛 FIX: Lib Compress/Base64 removal

* 📖 DOC: Update TOC

* 10.02 (#19)

* 🐛 FIX: 10.02 Fixes

* 🐛 FIX: Durability fix

* 🐛 FIX: Tooltip sticking around

* 📖 DOC: Update TOC

* 🤖 TEST: Remove unused vars

* 🐛 FIX: CI Fix

Co-authored-by: Wolen <wolen2102@gmail.com>

* 🐛 FIX: Added Retail checks for Classic functions (#20)

* 🐛 FIX: Added Retail checks for Classic functions

* 🤖 TEST: CI

* 🤖 TEST: For real this time

* 📖 DOC: dragons am i right

* 📖 DOC: Update evoker colors

* 🤖 TEST: personal micromenu chng

* 📖 DOC: Update evoker spec icons

* 📖 DOC: Make WindTools required

* 📖 DOC: Bump ElvUI req. version

* 📖 DOC: Update chat badges

* 🤖 TEST: personal WA change

* ‼️ BREAKING: Maybe fix WA skin windtools thingy?

* 🤖 TEST:Disable force gradient mode during install

* 🐛 FIX: Fix healer party buffs anchor

* ‼️ BREAKING: follow-up to WA skin "fix"

* 👌 IMPROVE: Apply nawu's tag patch

* 📖 DOC: Bump TOC for elvui req. vers

* 🐛 FIX: Fix secure flyouts

* 📖 DOC: Update changelog

* 📖 DOC: Add github to contacts (need logo)

* 🚀 RELEASE: 6.1.0

* 📖 DOC: Prepare TOC for 6.1.2

* 👌 IMPROVE: Update plater mods

* 📖 DOC: CL update

* 🤖 TEST: personal wb chng

* 🐛 FIX: Fix gradient dead color?

* 👌 IMPROVE: Move vigor bar down

* 👌 IMPROVE: Remove talking head mover

* 👌 IMPROVE: Remove totem bar stuff

* 👌 IMPROVE: Update rogue gradient color

* 🤖 TEST: toxi personal

* 📦 NEW: Add Evoker spec icons to WB & Armory

* 👌 IMPROVE: Add valdrakken portals for mages

* 📦 NEW: Change default WB background

* 👌 IMPROVE: Add tol barad portals for mages

* 🤖 TEST: toxi personal wb

* 👌 IMPROVE: Minimap hide tracking & upscale LFG

* 📖 DOC: Organize couple changelogs a bit

* 🤖 TEST: Fix CL LUA error

* 🤖 TEST: Toxi personal WT change

* 🐛 FIX: maybe fix splashscreen error

* Dragonriding (#22)

* 📦 NEW: Dragonriding Vehiclebar toggle

* 🤖 TEST: Fixed extra bonusbar

* DOC: Update v0dka names

* Support for the dragonflight enchant/socket system (#23)

* 👌 IMPROVE: Dragonflight enchantments support

* 📦 NEW: Optional missing socket support on necklaces

* 📖 DOC: Changelog

* 🤖 TEST: Update toxi char names

* 📦 NEW: missing sockets and enchants code (#24)

* 👌 IMPROVE: missing sockets and enchants code

* 📖 DOC: Update checkbox descriptions

* 👌 IMPROVE: Small tweaks to FastColorGradientHex

* 📖 DOC: Changelog update

* 📖 DOC: Enable missing sockets by default

* 👌 IMPROVE: Rename `messageCondition`

Co-authored-by: Tomas Leonavičius <69549795+Toxicom@users.noreply.github.com>

* 🤖 TEST: personal

* 🤖 TEST: Change wb bg personal

* 👌 IMPROVE: Focus Frame reposition (#25)

* 👌 IMPROVE: Update Plater mods

* 🐛 FIX: Vehicle bar taint (#26)

* 📖 DOC: Changelog

* 📖 DOC: Init 6.1.3

* 👌 IMPROVE: Disable plater target color

* 🐛 FIX: Disable plater coloring for rares

* 👌 IMPROVE: Force disable ElvUI UW support

* 👌 IMPROVE: Remove gigachad resolution calc

* 📖 DOC: CL Update

* 👌 IMPROVE: Update ElvUI Globals

-   Move World Map coordinates to bottom right;
-   Increase default elvui options window size.

* 📖 DOC: Bump required elvui version

* 🤖 TEST: Personal bag font change

* 🤖 TEST: Test discord webhook

* 📦 NEW: Add Hoffi badge names

* 🐛 FIX: Raid groups' visiblity state

* 🤖 TEST: personal toxi

* 🤖 TEST: personal dk color

* 📦 NEW: Title Secondary font

* 📖 DOC: Update font description

* 📖 DOC: Bump required ElvUI version

* 🐛 FIX: Wrath Ulduar API changes

* 📖 DOC: Update changelog

* 🤖 TEST: luacheck

* 📖 DOC: Init 6.1.4

* 🐛 FIX: UI Scale for 2160p

* 🐛 FIX: Debug messages in stable

* 📖 DOC: Init 6.1.5

* 📖 DOC: Reduce log level for dev release

* 📖 DOC: Bump TOC

* 🐛 FIX: Disable guild tooltip and rightclick

* 📖 DOC: Init 6.1.6

* FIX: Correctly style details deaths when using gradient theme. (#36)

* 📖 DOC: Update changelog

* #40 Installer changes (#42)

---------

Co-authored-by: Wolen <wolen2102@gmail.com>
Co-authored-by: Uncaught3xception <67075781+Uncaught3xception@users.noreply.github.com>
Co-authored-by: Chris Ward <cdurianward@gmail.com>
Co-authored-by: Rochelle <RyadaProductions@users.noreply.github.com>
Co-authored-by: Brendan Martens <shrift@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] VehicleBar: Taint
3 participants
@RyadaProductions @nawuko @Toxicom