ClientAwaitedAction now uses a channel to notify drops happened

Instead of using Weak references and custom spawns, we now use a channel to notify receivers that cleanups are needed.
TraceMachina · Jul 10, 2024 · d34eab6 · d34eab6
1 parent 52beaf9
commit d34eab6
Show file tree

Hide file tree

Showing 3 changed files with 139 additions and 148 deletions.
diff --git a/nativelink-scheduler/src/cache_lookup_scheduler.rs b/nativelink-scheduler/src/cache_lookup_scheduler.rs
@@ -227,7 +227,6 @@ impl ActionScheduler for CacheLookupScheduler {
             .await;
             match maybe_action_result {
                 Ok(action_result) => {
-                    println!("{action_result:?}");
                     let maybe_pending_txs = {
                         let mut inflight_cache_checks = inflight_cache_checks.lock();
                         // We are ready to resolve the in-flight actions. We remove the

diff --git a/nativelink-scheduler/src/scheduler_state/awaited_action.rs b/nativelink-scheduler/src/scheduler_state/awaited_action.rs
@@ -68,7 +68,7 @@ pub struct AwaitedAction {
     action_info: Arc<ActionInfo>,
 
     // The unique identifier of the operation.
-    // TODO(operation_id should be stored here).
+    // TODO!(operation_id should be stored here).
     // operation_id: OperationId,
     /// The data that is used to sort the action in the queue.
     /// The first item in the tuple is the current priority,