-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENG-48260: Update to fix environment name conflict #28
Conversation
So does tme also execute the code to set the |
Yes @tim-mwangi, since tme is basically a smaller tpa without collector! It uses same image and code, just different configs. |
gen/go/proto/v1/config.proto
Outdated
// represents the environment name of agent | ||
google.protobuf.StringValue environment = 10; | ||
// AgentAttributesConfig has the parameters specific to an agent | ||
AgentAttributesConfig agent_attributes_config = 10; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also seems like the agentAttributes processor config we have.
Need to think about another name maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm..thought about it while naming. Want to have some thing which specifies this corresponds of parameters specific to an agent (as we may populate it in future). Something like AgentParametersConfig
?. I am out of naming ideas tbh.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about HostDetails or ServixeDetails ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I go with AgentHostAttributes
as @varkey98 suggested? Or do you have any suggestions @ryanericson @tim-mwangi @shashank11p @puneet-traceable .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AgentHostAttributes is also a potential name, I like this better
Ok. I see the code in agent.go |
No description provided.