Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-48260: Update to fix environment name conflict #28

Closed
wants to merge 2 commits into from

Conversation

thugrock7
Copy link
Contributor

No description provided.

@tim-mwangi
Copy link
Contributor

So does tme also execute the code to set the default environment when TA_ENVIRONMENT is not set?

@shashank11p
Copy link
Contributor

So does tme also execute the code to set the default environment when TA_ENVIRONMENT is not set?

Yes @tim-mwangi, since tme is basically a smaller tpa without collector! It uses same image and code, just different configs.

// represents the environment name of agent
google.protobuf.StringValue environment = 10;
// AgentAttributesConfig has the parameters specific to an agent
AgentAttributesConfig agent_attributes_config = 10;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also seems like the agentAttributes processor config we have.
Need to think about another name maybe?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm..thought about it while naming. Want to have some thing which specifies this corresponds of parameters specific to an agent (as we may populate it in future). Something like AgentParametersConfig?. I am out of naming ideas tbh.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about HostDetails or ServixeDetails ?

Copy link
Contributor Author

@thugrock7 thugrock7 Aug 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I go with AgentHostAttributes as @varkey98 suggested? Or do you have any suggestions @ryanericson @tim-mwangi @shashank11p @puneet-traceable .

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AgentHostAttributes is also a potential name, I like this better

@tim-mwangi
Copy link
Contributor

So does tme also execute the code to set the default environment when TA_ENVIRONMENT is not set?

Yes @tim-mwangi, since tme is basically a smaller tpa without collector! It uses same image and code, just different configs.

Ok. I see the code in agent.go

@varkey98 varkey98 closed this Aug 12, 2024
@varkey98 varkey98 deleted the UpdateEnvNameConflict branch August 12, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants