Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TopBar] buttons in Aside will fail in mobile breakpoint #131

Closed
wiredearp opened this issue Jan 27, 2017 · 0 comments · Fixed by #143
Closed

[TopBar] buttons in Aside will fail in mobile breakpoint #131

wiredearp opened this issue Jan 27, 2017 · 0 comments · Fixed by #143
Labels
issue: bug
Milestone
v7.0.0

Comments

@wiredearp
Copy link
Contributor

The method putAside (which moves the buttons into an Aside menu) fails miserably for the following reason:

Unexpected edb.Object constructor argument of type array: [object Object],[object Object]

Steps to reproduce:

  1. Resize down to mobile breakpoint
  2. Go to http://ui.tradeshift.com/#components/bars/topbar.html
  3. Find "Button Groups" and click Run This Code
  4. Click the ... button in the TopBar to launch the Aside
  5. Behold the failure
@wiredearp wiredearp added this to the 7.0.0 milestone Feb 7, 2017
wiredearp added a commit that referenced this issue Feb 7, 2017
@wiredearp
Fix #131
d0dde6b
@wiredearp wiredearp mentioned this issue Feb 8, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
issue: bug
Projects
None yet
Milestone
v7.0.0
Development

Successfully merging a pull request may close this issue.

Some fixes Tradeshift/tradeshift-ui
1 participant
@wiredearp