Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Table] Support images in Table #87

Closed
n-srg opened this issue Dec 8, 2016 · 5 comments
Closed

[Table] Support images in Table #87

n-srg opened this issue Dec 8, 2016 · 5 comments

Comments

@n-srg
Copy link
Contributor

n-srg commented Dec 8, 2016

Currently we can insert only ts-icons in table cells using the code below

function geticon(type, color = 'black') {
	return {
		item: 'Icon',
		type: type,
		color: color
	}
}

But in fact we need to implement handling external images (e.g. .PNG and other image types)

@tcomboeanu
Copy link
Contributor

tcomboeanu commented Jan 25, 2017

It would be nice if we can also include a UserImage in a table cell. 💪

@wiredearp
Copy link
Contributor

@tcomboeanu and @n-srg and @vvvts Better late than never, we now have minimum viable support for images and UserImages on the Table over on http://ui.tradeshift.com/#components/table/extras.html (it's in the 7.0.0-alpha.26 release which is not yet merged to master in V4). We figure that we will need to support this with some additional features, not least a fixed width for the column that contains the images (we currently only have a minwidth for the columns) and perhaps we also need to support a UserCard which, in addition to the image, also shows the name and email address of the user (?). In any case, feel free to add additional feature requests here so we can keep the issue alive 🍺

@n-srg
Copy link
Contributor Author

n-srg commented Feb 14, 2017

@wiredearp sound like magic. much thanks! will use it when it will come to v4. 🍻

any thoughts about release date for v4?

@wiredearp
Copy link
Contributor

@n-srg The next release comes out with an extensive revision of the Forms UI and since it must be released into all the apps at once, we'll have to first allow everyone (including you) to test the next release in their favorite app and then implement the fixes that needs to be done. So I can't really promise an exact date 😢 but you can of course start testing your app today by setting the Runtime to 7.0.0-alpha.26 in config.json in the Apps-Server (and then restart the server) just to see if anything explodes.

@vvvts
Copy link

vvvts commented Feb 15, 2017

Looks great here http://ui.tradeshift.com/#components/table/extras.html! 🍻
Will try in apps...

@sampi sampi changed the title [table] Support images in Table [Table] Support images in Table Feb 15, 2017
@sampi sampi modified the milestones: v7.1.0, v7.0.0 Mar 17, 2017
@sampi sampi modified the milestones: v7.0.0, v7.1.0 Mar 28, 2017
@sampi sampi closed this as completed Mar 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants