Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UserImage] Support for table and aside selector #142

Closed
nsp918 opened this issue Feb 7, 2017 · 2 comments
Closed

[UserImage] Support for table and aside selector #142

nsp918 opened this issue Feb 7, 2017 · 2 comments

Comments

@nsp918
Copy link

nsp918 commented Feb 7, 2017

I am working on Task manager which requires a way to select and manage users / teams.
It would be great to have UserImages shown in table and aside selectors.
Here are some concept arts:
screen shot 2017-02-07 at 12 05 55
screen shot 2017-02-07 at 12 07 44

@wiredearp
Copy link
Contributor

wiredearp commented Feb 7, 2017

  1. There's an existing request for UserImage in Table over on [Table] Support images in Table #87 (although I'm not completely sure you would want that team overview as a Table). We'll work on that feature sometimes soon.
  2. You can already put the UserImage in the Aside, since it can contain any kind of HTML.

... But maybe you are requesting a UserCard instead of just an image, which also shows the name and email address? In that case, @jerf, that would be the UserCard in an "inline card" form factor (where we currently only support in in an Aside "details" view). Do we want to support the entire UserSelector component?

It also looks like you can request another component based on the screenshot: The TeamImage (and the TeamCard, which also shows the name). I know we've had requests on this from @tstapleton sometimes earlier, but the feature request was lost in time 😢

@wiredearp wiredearp modified the milestone: 7.0.0 Feb 8, 2017
@wiredearp
Copy link
Contributor

@nsp918: I've added a section about about picking user(s) from a list over on http://ui.tradeshift.com/#components/userimages/.

Note that you can't use it even if you want to 😢 You can only use it if you upgrade your local development machine to use the latest alpha version of Tradeshift UI (version 7.0.0-alpha.24) and we are not completely sure when that will be in master for the app to use in production. Also: The design has not been approved yet (by @jerf) and it also doesn't look like the design you have, it is however (more) consistent with the other selection lists in Tradeshift UI.

marinalecuts pushed a commit to marinalecuts/tradeshift-ui that referenced this issue Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants