Fix broken ESCAPE and ENTER other special keys #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampi
reviewed
Jan 29, 2018
| @@ -129,8 +129,21 @@ gui.KeysModule = gui.module('gui-keys@wunderbyte.com', { | |||
| * @param {String} sig Contextkey | |||
| */ | |||
| _maybebroadcast: function(down, key, c, code, sig) { | |||
| if (!c) { | |||
| this._broadcast(down, key, c, code, sig); | |||
| switch (code) { | |||
There was a problem hiding this comment.
might as well add all the codes from https://w3c.github.io/uievents/#fixed-virtual-key-codes
did a quick regex on the table: (.*)\t(\d+) => case $2: // $1
case 8: // Backspace
case 9: // Tab
case 13: // Enter
case 16: // Shift
case 17: // Control
case 18: // Alt
case 20: // CapsLock
case 27: // Escape
case 32: // Space
case 33: // PageUp
case 34: // PageDown
case 35: // End
case 36: // Home
case 37: // ArrowLeft
case 38: // ArrowUp
case 39: // ArrowRight
case 40: // ArrowDown
case 46: // Delete
sampi
approved these changes
Jan 29, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kaumac @zdlm @sampi
Fixes issue #468 - Shaky ESCAPE from Aside + unreported issue: Table navigation broken (in edit mode). The infamous "key loggger" fix did apparently break the mechanism that will broadcast special keystrokes and this would lead to shaky key handling. Confusing because the keys would work when pressed repeatedly, so I assumed it was something with my keyboard 😞