Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong value in copypaste scenario + breakpoints on iOS + small fixes #563

Merged
merged 18 commits into from
Mar 9, 2018
Merged

Wrong value in copypaste scenario + breakpoints on iOS + small fixes #563

merged 18 commits into from
Mar 9, 2018

Conversation

wiredearp
Copy link
Contributor

@wiredearp wiredearp commented Mar 9, 2018 •
edited
Loading

@zdlm @sampi

@wiredearp wiredearp changed the title Jmo/fixes Fixes #562 - wrong value in copypaste scenario Mar 9, 2018
@wiredearp
Fix test (was using deprecated attribute syntax)
93dce47
@wiredearp
Measure innerWidth differently
e14b4d3 
Perhaps more reliable on iOS. Must unfortunately release this on the
internet to confirm, since Browserstack doesn't run iOS via local
tunnel.
@wiredearp wiredearp changed the title Fixes #562 - wrong value in copypaste scenario Fixes #562 - wrong value in copypaste scenario + small fixes Mar 9, 2018
sampi
sampi approved these changes Mar 9, 2018
View reviewed changes
Copy link
Contributor

@sampi sampi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@wiredearp wiredearp changed the title Fixes #562 - wrong value in copypaste scenario + small fixes Fixes #562 - wrong value in copypaste scenario + akpoints on iOS + bresmall fixes Mar 9, 2018
@wiredearp wiredearp changed the title Fixes #562 - wrong value in copypaste scenario + akpoints on iOS + bresmall fixes Wrong value in copypaste scenario + akpoints on iOS + bresmall fixes Mar 9, 2018
@wiredearp wiredearp changed the title Wrong value in copypaste scenario + akpoints on iOS + bresmall fixes Wrong value in copypaste scenario + breakpoints on iOS + bresmall fixes Mar 9, 2018
@wiredearp wiredearp changed the title Wrong value in copypaste scenario + breakpoints on iOS + bresmall fixes Wrong value in copypaste scenario + breakpoints on iOS + mall fixes Mar 9, 2018
@wiredearp wiredearp changed the title Wrong value in copypaste scenario + breakpoints on iOS + mall fixes Wrong value in copypaste scenario + breakpoints on iOS + small fixes Mar 9, 2018
@wiredearp wiredearp merged commit 44caff8 into master Mar 9, 2018
@wiredearp wiredearp deleted the jmo/fixes branch March 9, 2018 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sampi sampi sampi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wiredearp @sampi