wrapper: Load libraries globally instead of relative to $PWD
#74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no real reason to force `./` in default paths when the library is more and more likely to be installed on the system via `PATH` (on Windows it's in the Vulkan SDK, on Linux `directx-shader-compiler` is a common package). Furthermore, stop appending this path to the optional `lib_path` argument, if that `lib_path` doesn't **exist** as a file. In the case that a user specifies a (relative) path that doesn't exist, this throws an obscure error that `libdxcompiler.so/./libdxcompiler.so` doesn't exist because we appended a precooked filename a second time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #68, CC @expenses, please check if this fixes things for you!
There's no real reason to force
./in default paths when the library is more and more likely to be installed on the system viaPATH(on Windows it's in the Vulkan SDK, on Linuxdirectx-shader-compileris a common package).Furthermore, stop appending this path to the optional
lib_pathargument, if thatlib_pathdoesn't exist as a file. In the case that a user specifies a (relative) path that doesn't exist, this throws an obscure error thatlibdxcompiler.so/./libdxcompiler.sodoesn't exist because we appended a precooked filename a second time.