Update AS descriptor type to KHR final Ray Tracing spec #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on rspirv being regenerated with the RT spec: gfx-rs/rspirv#174
We will have to decide on a proper release model for this, assuming not everyone might have updated to official spec yet. Instead of adding an API to keep the NV and KHR number apart which are now different we might expect application users to deal with this in their own code (ie. translating
ACCELERATION_STRUCTURE_KHRtoACCELERATION_STRUCTURE_NV), or we can determine it based on the capability flagRayTracingNVvsRayTracingKHRwhich are different values.