Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle OpTypePointer in type size; introduce GLSL tests #5

Merged
merged 4 commits into from
May 13, 2023
Merged

Conversation

MarijnS95
Copy link
Member

@MarijnS95 MarijnS95 commented Oct 2, 2020

Fixes #29, fixes #30

A couple small fixes to arrays and image+sampler combinations to enable GLSL support, complete with tests that I assume represent expected descriptor info. almost all GLSL support patches and fixes have already been merged, complete it by fixing one sizing issue and adding some test cases for GLSL shaders.

@MarijnS95 MarijnS95 changed the title WIP: Preliminary GLSL support and tests GLSL tests Mar 5, 2023
@MarijnS95 MarijnS95 marked this pull request as ready for review March 5, 2023 22:07
@MarijnS95 MarijnS95 changed the title GLSL tests Handle OpTypePointer in type size; introduce GLSL tests Apr 15, 2023
@MarijnS95 MarijnS95 requested a review from tosti007 May 6, 2023 22:44
@MarijnS95 MarijnS95 merged commit 42e65e1 into main May 13, 2023
@MarijnS95 MarijnS95 deleted the glsl branch May 15, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reflection::get_descriptor_sets doesn't list samplers Wrong push constant size when using buffer references.
1 participant