update AWS KMS transaction signing fields (#143)

TreasureProject · Oct 16, 2024 · b82e78b · b82e78b
1 parent 79e7179
commit b82e78b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/.changeset/hip-bugs-complain.md b/.changeset/hip-bugs-complain.md
@@ -0,0 +1,5 @@
+---
+"@treasure-dev/tdk-core": patch
+---
+
+Updated AWS KMS transaction signing fields
diff --git a/packages/core/src/connect/kms.ts b/packages/core/src/connect/kms.ts
@@ -37,15 +37,16 @@ export const getAwsKmsAccount = async ({
 
     const r = `0x${signature.r.toString("hex")}` as Hex;
     const s = `0x${signature.s.toString("hex")}` as Hex;
-    const v = signature.v;
+    const v = BigInt(signature.v);
 
-    const yParity = v % 2 === 0 ? 1 : (0 as 0 | 1);
+    const yParity: 0 | 1 = signature.v % 2 === 0 ? 1 : 0;
 
     const signedTx = serializeTransaction({
       transaction: tx,
       signature: {
         r,
         s,
+        v,
         yParity,
       },
     });