Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elastic-search: remove default index migrator #492

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

osoykan
Copy link
Collaborator

@osoykan osoykan commented Jun 24, 2024

There is no need to force es to create an index while starting, user can write a migration for that.

@osoykan osoykan force-pushed the elastic-remove-default-index-migrator branch from 90c2df7 to 28f020b Compare June 24, 2024 13:33
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 88.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 83.54%. Comparing base (d985a83) to head (90c2df7).

Current head 90c2df7 differs from pull request most recent head 28f020b

Please upload reports for the commit 28f020b to get more accurate results.

Files Patch % Lines
...e/testing/e2e/elasticsearch/ElasticsearchSystem.kt 87.50% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #492      +/-   ##
==========================================
- Coverage   84.01%   83.54%   -0.48%     
==========================================
  Files          84       84              
  Lines        2046     2036      -10     
  Branches       89       92       +3     
==========================================
- Hits         1719     1701      -18     
- Misses        272      277       +5     
- Partials       55       58       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@osoykan osoykan merged commit 7ab7eca into main Jun 24, 2024
1 check passed
@osoykan osoykan deleted the elastic-remove-default-index-migrator branch June 24, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant