Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cientos): 178 v-light-helper #214

Merged
merged 6 commits into from
Sep 18, 2023
Merged

Conversation

JaimeTorrealba
Copy link
Member

This will not close the issue 178

@netlify
Copy link

netlify bot commented Sep 15, 2023

Deploy Preview for cientos-tresjs ready!

Name Link
🔨 Latest commit 5254ac2
🔍 Latest deploy log https://app.netlify.com/sites/cientos-tresjs/deploys/6508693d3ef2b30008f855d3
😎 Deploy Preview https://deploy-preview-214--cientos-tresjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

src/core/directives/vLightHelper.ts Outdated Show resolved Hide resolved
@alvarosabu alvarosabu self-requested a review September 16, 2023 15:38
</template>
```

Note that you can pass a modifier with the name of a property, for example `v-log:material`, and will log directly the `material` property
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy paste ;) @JaimeTorrealba

@alvarosabu
Copy link
Member

alvarosabu commented Sep 16, 2023

@JaimeTorrealba dunno if it's possible but add an update call helper.update() everytime there is a change in the light. Otherwise the helper will remain in the same place if you move the light or change the color

@JaimeTorrealba
Copy link
Member Author

Interesting, I could use it with the renderLoop, or in the update directive cycle

  1. With the renderloop is the same as the request animation frame, will not be performance problems right?
  2. Option 2 it will only trigger when a reactive property (Vue) of the element changes (which is not always the case)

@alvarosabu
Copy link
Member

Interesting, I could use it with the renderLoop, or in the update directive cycle

  1. With the renderloop is the same as the request animation frame, will not be performance problems right?
  2. Option 2 it will only trigger when a reactive property (Vue) of the element changes (which is not always the case)

I will go for the second option since the update is not like the controls.update() which needs to be inside of the renderLoop

@alvarosabu alvarosabu merged commit 0652eed into main Sep 18, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants