Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(SVG): add demo, update usage, add troubleshooting tip #231

Merged
merged 4 commits into from
Sep 24, 2023

Conversation

andretchen0
Copy link
Contributor

  • Adds a live demo to the <SVG /> component.
  • Updates usage example: standalone SFC, matches demo
  • Adds troubleshooting tips if <SVG /> is not visible

@andretchen0 andretchen0 marked this pull request as ready for review September 22, 2023 19:00
@netlify
Copy link

netlify bot commented Sep 22, 2023

Deploy Preview for cientos-tresjs ready!

Name Link
🔨 Latest commit 3bd7de4
🔍 Latest deploy log https://app.netlify.com/sites/cientos-tresjs/deploys/650de44df625f60008363363
😎 Deploy Preview https://deploy-preview-231--cientos-tresjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@andretchen0
Copy link
Contributor Author

@JaimeTorrealba

I haven't merged before and don't want to step on anyone's toes.

Do you want me to merge?

Thanks!

@JaimeTorrealba JaimeTorrealba merged commit 630f381 into main Sep 24, 2023
6 checks passed
@andretchen0 andretchen0 deleted the docs/svgdemo branch September 24, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants