feat: 209 global audio #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cientos-tresjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
andretchen0
requested changes
Oct 5, 2023
There was a problem hiding this comment.
Hey @JaimeTorrealba , the demo didn't work for me, so I couldn't try it out. I marked the line that the error sent me to and made some other remarks.
Once that's fixed, rerequest a review and I'll have another look. 🙂
andretchen0
reviewed
Oct 5, 2023
andretchen0
approved these changes
Oct 5, 2023
|
Great. Everything works now and the other changes look good. 👍 I approved the review, but made one more comment above. I don't know if it's doable or within the scope of the work here, so feel free to ignore it. |
…se state when is playing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #209