Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: ignore .DS_Store everywhere, components.d.ts #266

Merged
merged 1 commit into from
Oct 24, 2023
Merged

chore: ignore .DS_Store everywhere, components.d.ts #266

merged 1 commit into from
Oct 24, 2023

Conversation

andretchen0
Copy link
Contributor

@andretchen0 andretchen0 commented Oct 23, 2023 •
edited
Loading

Problem

  • .DS_Store files outside of the root directory aren't being ignored
  • /docs/components.d.ts is autogenerated and gets created/updated whenever a docs component is created/updated – leading to merge conflicts

Solution

Change .gitignore

@stackblitz
Copy link

stackblitz bot commented Oct 23, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Oct 23, 2023 •
edited
Loading

✅ Deploy Preview for cientos-tresjs ready!

Name Link
🔨 Latest commit e47cb6f
🔍 Latest deploy log https://app.netlify.com/sites/cientos-tresjs/deploys/65365d885a87a30008e0c72d
😎 Deploy Preview https://deploy-preview-266--cientos-tresjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@andretchen0 andretchen0 marked this pull request as ready for review October 23, 2023 11:49
@alvarosabu alvarosabu merged commit 1252c63 into main Oct 24, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andretchen0 @alvarosabu