Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 28 stars #34

Merged
merged 8 commits into from
Apr 19, 2023
Merged

feat: 28 stars #34

merged 8 commits into from
Apr 19, 2023

Conversation

JaimeTorrealba
Copy link
Member

@JaimeTorrealba JaimeTorrealba commented Apr 12, 2023 •
edited by alvarosabu
Loading

As always any feedback is well received

  1. I decided to not include any shader in this implementation (we can add if we needed in the future)
  2. In the docs section, could be a good idea to put a StackBlitzEmbed on a next interaction

close #28

@JaimeTorrealba JaimeTorrealba added v2 feature New feature or request labels Apr 12, 2023
@JaimeTorrealba JaimeTorrealba self-assigned this Apr 12, 2023
alvarosabu
alvarosabu requested changes Apr 12, 2023
View reviewed changes
Copy link
Member

@alvarosabu alvarosabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, I like this abstraction, is gonna add a nice touch.

I left you some feedback, take a look and if you have any question let me know :)

playground/src/pages/index.vue Outdated Show resolved Hide resolved
src/core/Stars.vue Show resolved Hide resolved
src/core/Stars.vue Outdated Show resolved Hide resolved
@alvarosabu
Copy link
Member

Please change the title to feat: 28 starts

@JaimeTorrealba JaimeTorrealba changed the title Feature/28 stars Feature: 28 stars Apr 19, 2023
@JaimeTorrealba JaimeTorrealba changed the title Feature: 28 stars feat: 28 stars Apr 19, 2023
@alvarosabu alvarosabu merged commit 4fc7f4f into next Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarosabu alvarosabu Awaiting requested review from alvarosabu

Assignees

@JaimeTorrealba JaimeTorrealba

Labels
feature New feature or request v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JaimeTorrealba @alvarosabu