Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update tres eslint #388

Merged
merged 5 commits into from
Apr 30, 2024
Merged

chore: update tres eslint #388

merged 5 commits into from
Apr 30, 2024

Conversation

alvarosabu
Copy link
Member

This applies the new flat linter to cientos

Copy link

stackblitz bot commented Apr 29, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@JaimeTorrealba
Copy link
Member

Is crashing the lock, remember how to solve that?

I know is easy but I don't remember right now jejeje

image

@alvarosabu
Copy link
Member Author

@JaimeTorrealba I will take a look

@JaimeTorrealba JaimeTorrealba merged commit 26d2831 into main Apr 30, 2024
2 checks passed
@andretchen0
Copy link
Contributor

andretchen0 commented May 1, 2024

Update

Running pnpm i fixed it.


I'm getting eslint errors after merging the latest main branch into a recent pull request.

pnpm run lint --fix

... leads to ...

cientos % pnpm run lint --fix

> @tresjs/cientos@3.8.0 lint /me/oss/cientos
> eslint . "--fix"


Oops! Something went wrong! :(

ESLint: 8.56.0

Error [ERR_MODULE_NOT_FOUND]: Cannot find package '@tresjs/eslint-config' imported from /me/oss/cientos/eslint.config.js
    at packageResolve (node:internal/modules/esm/resolve:844:9)
    at moduleResolve (node:internal/modules/esm/resolve:901:20)
    at defaultResolve (node:internal/modules/esm/resolve:1131:11)
    at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:390:12)
    at ModuleLoader.resolve (node:internal/modules/esm/loader:359:25)
    at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:234:38)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/module_job:85:39)
    at link (node:internal/modules/esm/module_job:84:36)

As a consequence, can't push without the --no-verify flag and the linter CI step fails.

@andretchen0
Copy link
Contributor

@alvarosabu

The new linter rules break valid Markdown. Please see: #398

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants