Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Torrent Checker refactoring #7286

Merged
merged 41 commits into from
Feb 20, 2023
Merged

Torrent Checker refactoring #7286

merged 41 commits into from
Feb 20, 2023

Conversation

drew2a
Copy link
Contributor

@drew2a drew2a commented Jan 25, 2023 •
edited
Loading

This PR related to #6131, fixes #7287

Changes:

  • logging has been extended
  • fixed types inconsistency
  • fixed run_tribler_headless.py (it was run without components)
  • fixed check_random_tracker (the result of checks were never saved in DB)
  • app_mode added to logging
  • fixed FakeDHTSession logic inconsistency
  • fixed recheck torrent health logic (@kozlovsky)
  • a tooltip was added to show the freshness of the seeders/leechers info (@kozlovsky)

@drew2a drew2a mentioned this pull request Jan 26, 2023
Open
@drew2a drew2a force-pushed the fix/6131 branch 3 times, most recently from 8a0c944 to 28e21d3 Compare January 27, 2023 09:29
@drew2a drew2a mentioned this pull request Jan 27, 2023
Open
@hbiyik
Copy link

hbiyik commented Jan 27, 2023 •
edited
Loading

Thanks for this, as someone who has spent some time in this part of code, i had seen lots of issues there. Not cosmetic-wise but flow-wise as well. Sorry can't provide an actual feedback it has been a long while, but i appreciate the bravery. I hope it can motive :)

@drew2a
Copy link
Contributor Author

drew2a commented Jan 28, 2023

@hbiyik thank you for your support! It's quite motivating!

@drew2a drew2a force-pushed the fix/6131 branch 8 times, most recently from 52e5640 to adb9d33 Compare February 1, 2023 11:23
@drew2a drew2a force-pushed the fix/6131 branch 2 times, most recently from 4c6c3a7 to 41b4634 Compare February 1, 2023 12:42
@drew2a drew2a mentioned this pull request Feb 2, 2023
Closed
@drew2a drew2a marked this pull request as ready for review February 3, 2023 17:02
@drew2a drew2a requested review from a team and kozlovsky and removed request for a team February 3, 2023 17:02
@kozlovsky
Refactoring of TorrentChecker.torrents_checked: use InfohashHealth in…
5e99c54 
…stead of tuples
@kozlovsky
Use InfohashHealth instead of tuples
e5453a5
@kozlovsky
Add TorrentState.from_health() and .to_health()
07ac62b
@kozlovsky
Renaming: tracker_manager.tracker_store -> tracker_manager.TorrentState
770e229
@kozlovsky
Remove default for InfohashHealth.last_check to make code less error-…
e7f0fa0 
…prone
@kozlovsky
Refactoring: remove TorrentChecker.check_torrents()
123605d
@kozlovsky
Add bool return value to TorrentChecker.update_torrent_health() to ma…
263b7ba 
…ke it clear that it is not always updates DB
@kozlovsky
Filter exceptions in FakeBep33DHTSession.connect_to_tracker() results
6f61849
@kozlovsky
Fix race condition in TorrentChecker.load_torrents_checked_from_db (t…
2ec525e 
…orrents are not loaded from the DB if a new health info was added to TorrentChecker._torrents_checked)
@kozlovsky
Fix: TorrentChecker.get_tracker_response() should propagate CanceledE…
50c10e8 
…rror to avoid returning None instead of TrackerResponse
@kozlovsky
Simplify dependencies.py
7c778b4
@kozlovsky
Add parsing of requirement lines with comments
865cdd4
@kozlovsky
Simplify conf.py
1c6a17b
@kozlovsky
Handle underscores in the package name
7a76fc4
@kozlovsky
Concise and readable custom repr for InfohashHealth
1d247f5
@kozlovsky
Reduce overall verbose logging
b23e1ed
@kozlovsky
Fix: update information about torrents with zero seeders in TorrentCh…
943a138 
…ecker.torrents_checked
@kozlovsky
Update health information for a torrent even if no successful respons…
9887bc4 
…es were received
@kozlovsky
Renaming: InfohashHealth -> HealthInfo
e134e10
@kozlovsky
Use get_for_update in TorrentChecker.update_torrent_health()
1ad1f23
@kozlovsky
Fix: when overriding self-checked health info with non-self-checked, …
8a0eb9e 
…update the self_checked flag in the DB
@kozlovsky
Log initially loaded torrent health info
1591652
@kozlovsky
Fix: do not load torrents with incorrect last_check time ("updated in…
8fea75d 
… the future") from the DB.

Such torrents can appear if a torrent health was self-checked on the local machine and then
updated with incorrect info from the remote machine without updating the self_checked flag.
@kozlovsky
Fix: do not update the health info in DB with incorrect health info (…
99d5725 
…with future time)
@kozlovsky
Fix: do not update recently checked local health info with remote hea…
2bfc9da 
…lth info
kozlovsky
kozlovsky suggested changes Feb 20, 2023
View reviewed changes
src/tribler/core/components/metadata_store/restapi/metadata_endpoint.py Outdated Show resolved Hide resolved
src/tribler/core/components/metadata_store/restapi/metadata_endpoint.py Outdated Show resolved Hide resolved
src/tribler/core/components/metadata_store/restapi/metadata_endpoint.py Outdated Show resolved Hide resolved
src/tribler/core/components/metadata_store/restapi/metadata_endpoint.py Outdated Show resolved Hide resolved
src/tribler/core/components/torrent_checker/torrent_checker/torrent_checker.py Outdated Show resolved Hide resolved
src/tribler/core/components/torrent_checker/torrent_checker/torrent_checker.py Outdated Show resolved Hide resolved
src/tribler/core/components/torrent_checker/torrent_checker/torrent_checker.py Outdated Show resolved Hide resolved
src/tribler/core/components/torrent_checker/torrent_checker/torrentchecker_session.py Outdated Show resolved Hide resolved
src/tribler/core/components/torrent_checker/torrent_checker/torrent_checker.py Outdated Show resolved Hide resolved
src/tribler/core/components/torrent_checker/torrent_checker/torrent_checker.py Outdated Show resolved Hide resolved
@kozlovsky kozlovsky self-requested a review February 20, 2023 07:21
@kozlovsky kozlovsky merged commit 3e5f265 into Tribler:main Feb 20, 2023
@kozlovsky kozlovsky mentioned this pull request Feb 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kozlovsky kozlovsky kozlovsky approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[main] Recheck torrent health is broken
3 participants
@drew2a @hbiyik @kozlovsky