Close database connections after exiting from the db_session to avoid access violation on Python 3.10 #7945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kozlovsky
requested review from
a team and
egbertbouman
and removed request for
a team
kozlovsky
force-pushed
the
fix/python10-access-violation
branch
from
1dbe9a4 to
1d4c49b
Compare
xoriole
approved these changes
Mar 27, 2024
… access violation on Python 3.10
kozlovsky
force-pushed
the
fix/python10-access-violation
branch
from
1d4c49b to
a84ba12
Compare
kozlovsky
added a commit
that referenced
this pull request
Mar 27, 2024
…db_session to avoid access violation on Python 3.10 (cherry picked from commit a84ba12)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #7728 by closing all database connections after the db_session finishes.
If we plan to release a bugfix version for the current release, it is worth to cherry-pick this fix to the current release branch as well, as some reported access violations can be caused by this problem as well.