Fix binary build #7949
Merged
Fix binary build #7949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
xoriole
commented
Mar 27, 2024
xoriole
commented
- cx_Freeze build is missing openssl DLLs on windows. This PR adds these DLLs during the build process.
- It fixes the issue with building binaries and wheel using the setup.py script. Cx_Freeze does not support building wheels so build script is made conditional.
xoriole
requested review from
a team and
kozlovsky
and removed request for
a team
kozlovsky
approved these changes
Mar 27, 2024
…binary build Add OpenSSL DLLs during build Move added DLLs to lib directory
xoriole
force-pushed
the
fix/build-binaries
branch
from
d47c90a to
d21806f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.