Alpine = AMD64, Debian = ARM #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JYC333
reviewed
Aug 28, 2024
JYC333
reviewed
Aug 28, 2024
JYC333
approved these changes
Aug 29, 2024
eliandoran
reviewed
Aug 30, 2024
| @@ -16,7 +16,7 @@ env: | |||
| DOCKERHUB_REGISTRY: docker.io | |||
| IMAGE_NAME: ${{ github.repository }} | |||
| TEST_TAG: triliumnext/notes:test | |||
| PLATFORMS: linux/amd64,linux/arm64 | |||
| PLATFORMS: linux/arm64,linux/arm/v7 | |||
There was a problem hiding this comment.
I probably should've renamed those ALPINE_PLATFORMS and DEBIAN_PLATFORMS respectively for our sanity. Copy and pasting all around clearly wasn't my brightest idea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the CI/CD again, to have Debian be for ARM, and Alpine be for AMD64.