Scripts/Elwynn Forest: Eastvale Peasant scripting #30271
+394
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced hacky scripting for Eastvale Peasants with proper scripting. Changes proposed: Replace Hacky SAI and pathing with C++ script. This scripting operates the same as official, a repeating order of 5 paths. Tests performed: Builds. Tested in game. Closes TrinityCore#16608
|
Working on adding StringId to 335 to rework this script. |
malcrom
changed the title
malcrom
changed the title
|
Updated. Waiting for complaints before converting sql for master. |
Some code cleanup.
Made script more robust in case of peasant death.
Some magic number cleanup and reordering paths.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced hacky scripting for Eastvale Peasants with proper scripting.
Changes proposed:
Replace Hacky SAI and pathing with C++ script. This scripting operates the same as official, a repeating order of 5 paths. Tests performed:
Builds. Tested in game.
Closes #16608