Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display the PID of a job's exec process as an additional logger field #497

Closed
jwreagor opened this issue Aug 24, 2017 · 4 comments
Closed

Comments

@jwreagor
Copy link
Contributor

I'm proposing a feature that would add an additional pid logger field of a job's exec'd process. It looks something like this...

INFO[0005] 'this is test'                                job=echo-test pid=8346

The goal is to delineate between various processes on a system under ContainerPilot's supervision. This also helps display changes in process ID's during reloads, etc.

I've already implemented this so this issue is a stub until I can post the diff (it's inline with another feature).

@tgross
Copy link
Contributor

tgross commented Aug 24, 2017

I like this idea! 👍

@ahelal
Copy link
Contributor

ahelal commented Aug 24, 2017

what about the job name ?

@tgross
Copy link
Contributor

tgross commented Aug 24, 2017

what about the job name ?

That's already included. ref jobs/config.go#L253

@jwreagor
Copy link
Contributor Author

This is next up on the list now that #512 has been merged. Look for a new PR soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants