You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Within ContainerPilot's discovery/consul_test.go we're currently utilizing an internal testing package created for Consul. If we're to continue testing a live consul process then we should execute and control the process ourselves. Another option is to stub out Consul's API or it's HTTP client within our unit tests and exercise this functionality with proper integration tests.
The text was updated successfully, but these errors were encountered:
This commit removes the use case within the discovery package's tests that
depended on an internal Consul test package, `testutil`. We replace this with
our own TestServer object which is responsible for executing a locally installed
`consul` binary. Consul is installed by our Makefile target `tools` for local
development use.
Ref: TritonDataCenter#528
This commit removes the use case within the discovery package's tests that
depended on an internal Consul test package, `testutil`. We replace this with
our own TestServer object which is responsible for executing a locally installed
`consul` binary. Consul is installed by our Makefile target `tools` for local
development use.
Ref: TritonDataCenter#528
This refactoring ended up going really well. We've pulled out a package while keeping another around that isn't as much of a moving target for internal Consul testing (testutil/retry). We're also tracking Consul 1.0.0 proper.
Ref: #519 (comment).
Within ContainerPilot's
discovery/consul_test.go
we're currently utilizing an internal testing package created for Consul. If we're to continue testing a liveconsul
process then we should execute and control the process ourselves. Another option is to stub out Consul's API or it's HTTP client within our unit tests and exercise this functionality with proper integration tests.The text was updated successfully, but these errors were encountered: