Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore log output for the Consul heartbeat timer #556

Closed
jwreagor opened this issue Apr 23, 2018 · 2 comments
Closed

Ignore log output for the Consul heartbeat timer #556

jwreagor opened this issue Apr 23, 2018 · 2 comments
Labels

Comments

@jwreagor
Copy link
Contributor

jwreagor commented Apr 23, 2018

Recently, we added a feature that logs timing/timer events when our log level is set to DEBUG (#534). This, or a combination with something else, is presenting excessive log output we simply do not need.

It looks like the following...

DEBU[0000] control: initialized router for control server
DEBU[0000] control: listening to /var/run/containerpilot.socket
DEBU[0000] event: {Startup global}
INFO[0000] control: serving at /var/run/containerpilot.socket
DEBU[0000] job1.Run start
INFO[0000] telemetry: serving at 127.0.0.1:9090
DEBU[0005] timer: {TimerExpired containerpilot.heartbeat}
INFO[0005] Service registered: containerpilot
DEBU[0010] timer: {TimerExpired containerpilot.heartbeat}
DEBU[0015] timer: {TimerExpired containerpilot.heartbeat}
DEBU[0020] timer: {TimerExpired containerpilot.heartbeat}
DEBU[0025] timer: {TimerExpired containerpilot.heartbeat}

This issue should be resolved by safely ignoring this log output by matching on the containerpilot.heartbeat event timer name. The original goal of this log output was to help debug jobs with intervals/timers.

Steps to reproduce

  • Enable the telemetry endpoint
  • Set log level to DEBUG
@jwreagor jwreagor added the bug label Apr 23, 2018
@jwreagor
Copy link
Contributor Author

Actually, this looks like it is setup by the service registry for the telemetry endpoint. It would still be nice to remove this unnecessary log output.

@jwreagor
Copy link
Contributor Author

jwreagor commented May 1, 2018

This can be added to #559 as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant