new docker version change ip on container restart

[frascuchon]

Hi,
When service restarts, no ip info it being updated on consul, so change hostname by host ip on service id for service registration.

Best regards

[misterbisson]

This changes the format of the service.Id, replacing the hostname with the hostIP, which breaks expectations elsewhere that this is used.

[frascuchon]

Hi,

So, when a container is restarted from docker, the service ip in consul should be updated, since this may change.

Thanks !

[tgross]

So, when a container is restarted from docker, the service ip in consul should be updated, since this may change.

@frascuchon I just want to make sure I understand the issue you're seeing here: when a container is stopped and then started elsewhere, its IP address may change. (This doesn't happen when I run docker-machine locally or on Joyent's Triton platform, but I agree that we should assume that there might be a platform where this does happen.) So you're proposing this change so that the IP address is updated in Consul.

In that scenario, the service registration will happen again and any IP address changes will be updated in Consul. I've verified independently that Agent.ServiceRegister will overwrite correctly. This means that, for example, if we have the container app-4fe70bfdef25 running at 172.17.0.20:8000 and it's moved to 172.17.0.21:8000 with the same container ID, Consul will pick up the change.

Am I misunderstanding the scenario you've outlined?

[frascuchon]

Hi @tgross.

You're right. I test in a local environment with a docker-machine (version 0.4.1) and i can see this behavior

[tgross]

Ok, looks like it's safe to close this then?