Retry heartbeat after initial service registration #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sending a heartbeat to a not-yet registered service fails on both the `discovery/consul` and `discovery/etcd` backends. Previously we'd catch the error, register the service, and return so that we'd send a passing heartbeat on the next health check poll. This change retries the heartbeat on the newly registered service so that we become healthy more quickly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #225
Sending a heartbeat to a not-yet registered service fails on both the
discovery/consulanddiscovery/etcdbackends. Previously we'd catch the error, register the service, and return so that we'd send a passing heartbeat on the next health check poll. This change retries the heartbeat on the newly registered service so that we become healthy more quickly.cc @misterbisson @jasonpincin @justenwalker