-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove etcd #281
Remove etcd #281
Conversation
Removed etcd and removed constraints on transitive dependencies for the Prometheus client (these versions are pinned in glide.lock). Bumping the version of `github.com/beorn7/perks` fixes a metrics bug in small sample sizes for the Prometheus client, so our test expectations for sensors needed to be updated to match. (ref beorn7/perks#2)
We'll also need to deprecate https://github.com/autopilotpattern/etcd |
We're getting an odd seemingly-unrelated integration test error here that bears looking into:
|
I dug into the failed integration test and it appears to just be that the Consul target used by the env vars test sometimes takes longer than 10 seconds to self-elect. I've increased the timeout and have been reliably able to get it to pass and we're now passing integration tests. In #282 I'll tweak the integration tests a bit so that we can share more of the test setup code and make the test targets a bit more clean / faster. |
Done in autopilotpattern/etcd#3. I've also updated the docs to remove the relevant sections. |
:pickles: |
|
This PR removes support for etcd in ContainerPilot v3. Removing this early in the development cycle will reduce the overall testing and development load.