Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove etcd #281

Merged
merged 4 commits into from
Feb 23, 2017
Merged

Remove etcd #281

merged 4 commits into from
Feb 23, 2017

Conversation

tgross
Copy link
Contributor

@tgross tgross commented Feb 17, 2017

This PR removes support for etcd in ContainerPilot v3. Removing this early in the development cycle will reduce the overall testing and development load.

Removed etcd and removed constraints on transitive dependencies for the
Prometheus client (these versions are pinned in glide.lock).

Bumping the version of `github.com/beorn7/perks` fixes a metrics bug in
small sample sizes for the Prometheus client, so our test expectations
for sensors needed to be updated to match.
(ref beorn7/perks#2)
@misterbisson
Copy link
Contributor

We'll also need to deprecate https://github.com/autopilotpattern/etcd

@tgross
Copy link
Contributor Author

tgross commented Feb 17, 2017

We're getting an odd seemingly-unrelated integration test error here that bears looking into:

2017/02/17 17:58:36 TEST: test_envvars
Creating testenvvars_consul_1
Timed out waiting for Consul.
2017/02/17 17:58:47 FAIL: test_envvars

@tgross
Copy link
Contributor Author

tgross commented Feb 17, 2017

I dug into the failed integration test and it appears to just be that the Consul target used by the env vars test sometimes takes longer than 10 seconds to self-elect.

I've increased the timeout and have been reliably able to get it to pass and we're now passing integration tests. In #282 I'll tweak the integration tests a bit so that we can share more of the test setup code and make the test targets a bit more clean / faster.

@tgross
Copy link
Contributor Author

tgross commented Feb 17, 2017

We'll also need to deprecate https://github.com/autopilotpattern/etcd

Done in autopilotpattern/etcd#3. I've also updated the docs to remove the relevant sections.

@misterbisson
Copy link
Contributor

:pickles:

@tgross
Copy link
Contributor Author

tgross commented Feb 21, 2017

(Holding this up for an internal discussion. Don't merge please.) Resolved. Merging!

@tgross tgross merged commit adbec9b into master Feb 23, 2017
@tgross tgross deleted the remove_etcd branch April 10, 2017 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants