Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move health checks back into job definition #319

Merged
merged 1 commit into from
Apr 11, 2017
Merged

Conversation

tgross
Copy link
Contributor

@tgross tgross commented Apr 10, 2017

This PR eliminates the separate checks package and moves health checks back under the job definition.

Included:

  • changing of terminology poll and frequency to interval in all user-facing configs (I've left these separate internally for clarity when they're side-by-side in the code
  • made log entries more consistent between watches, jobs, and sensors.
  • test_tasks in the integration tests was flaky because the timeout of one of tests was very close to its frequency (now "interval"), and the test has been constrained to eliminate this flakiness. An end-user that makes the timeout and interval very close together will not be able to guarantee a specific number of restarts if that field is set. This is an inherent limitation in handling the timeouts and restarts asynchronously, but it's also not really a problem under realistic use. We'll document it though.
  • a bunch of test and test fixture cleanup

cc @misterbisson @jasonpincin @geek @cheapRoc

@tgross
Copy link
Contributor Author

tgross commented Apr 10, 2017

I'll push up a PR matching these requirements to RFD86 later today or tomorrow morning.

@tgross
Copy link
Contributor Author

tgross commented Apr 11, 2017

Pushed up TritonDataCenter/rfd#32

@tgross tgross merged commit 22b6569 into master Apr 11, 2017
@tgross tgross deleted the remove_separate_checks branch May 16, 2017 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant