move health checks back into job definition #319
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR eliminates the separate
checks
package and moves health checks back under the job definition.Included:
poll
andfrequency
tointerval
in all user-facing configs (I've left these separate internally for clarity when they're side-by-side in the codewatches
,jobs
, andsensors
.test_tasks
in the integration tests was flaky because the timeout of one of tests was very close to its frequency (now "interval"), and the test has been constrained to eliminate this flakiness. An end-user that makes the timeout and interval very close together will not be able to guarantee a specific number ofrestarts
if that field is set. This is an inherent limitation in handling the timeouts and restarts asynchronously, but it's also not really a problem under realistic use. We'll document it though.cc @misterbisson @jasonpincin @geek @cheapRoc