split SIGCHLD from all other signal handlers in supervisor (v2) #492
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #490, in v2
This PR splits out the goroutine that handles the
SIGCHLD
signal from all other signal handlers. This lets us loop on that handler without worrying about spawning additional goroutines for each signal received and should prevent resource growth in the case where manySIGCHLD
signals land during the handling of one of them.cc @cheapRoc @roengram