config: Adjust loop function to allow ranges by strings/env vars #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adjusts the implementation of the template config function called `loop`. We make adjustments to allow for the loop function to take a string or environment variable as input. We use a simple switch statement with a type assertion and detect either a string or not. By default we continue using `int` types as normal. Also tests have been adjusted to demonstrate the working functionality. Fixes TritonDataCenter#554
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adjusts the implementation of the template config function called
loop. We make adjustments to allow for the loop function to take a string orenvironment variable as input. We use a simple switch statement with a type
assertion and detect either a string or not. By default we continue using
inttypes as normal. Also tests have been adjusted to demonstrate the working
functionality.
Fixes #554