Enable docker-compose to scale app. #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous docker-compose-local.yml specified the host port for the app service. As a result, running `docker-compose scale app=3` would fail because the second and third containers would attempt to bind to the same port on the docker host. By removing the host portion of the port configuration, docker-compose chooses random port numbers for the host when scaling the app. https://docs.docker.com/compose/compose-file/#ports
|
LGTM. Thanks for the catch, @dobbs |
tgross
added a commit
that referenced
this pull request
Dec 28, 2015
Enable docker-compose to scale app.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous docker-compose-local.yml specified the host port for the app service. As a result, running
docker-compose scale app=3would fail because the second and third containers would attempt to bind to the same port on the docker host. By removing the host portion of the port configuration, docker-compose chooses random port numbers for the host when scaling the app.https://docs.docker.com/compose/compose-file/#ports