Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRITER: ensure that no value greater than 0xFF is written to a buffer position. #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

husio-org
Copy link

NodeJS seems to automatically truncate values when writing to a buffer, mainly because NodeJS relies on native buffers.

However, when using this module in the browser (via browserify, or any other portability tool), the buffer is implemented in javascript which will accept values > 0xFF leading to malformed outputs of the writer.

The unit tests pass with this patch included.

@Voles
Copy link

Voles commented Dec 8, 2016

@husio-org can you fix the Travis build?

@stephenwvickers
Copy link

I have seen there is little progress on this project over the past few years. My project, the net-snmp project, depends on this project, so I have cloned it and migrated (i.e. copied) all the outstanding issues and pull requests.

I will be releasing a new version of my version of this project under the asn1-ber namespace on npmjs.org by the end of the week which should address this particular item (I've already pushed the current code to this namespace to reserve it).

I am now tracking all changes under my own copy at asn1-ber. Note that this is not a "fork" but a clone and fresh commit to a new repository. I have of course retained all copyrights and attributed back the original author.

There are quite a few projects dependant on this project, and I want to make sure there is momentum on the issues and feature requests reported.

@stephenwvickers
Copy link

Hi @husio-org

I am trying resolve this issue in my clone but I am not sure I understand where the issue is.

Can you please provide more details at the following ticket under my clone:

markabrahams/node-asn1-ber#10

Thanks

Steve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants