Introduce a mapping from bunyan levels to syslog levels. #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code is generic, though it's impossible to trigger it for new levels (any predefined levels will work) without some changes to bunyan. The test code necessarily depends on a version of bunyan that allows new levels to be created, see trentm/node-bunyan#300
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actual code is generic, though it's impossible to trigger it for new levels (any predefined levels will work) without some changes to bunyan. The test code necessarily depends on a version of bunyan that allows new levels to be created, see trentm/node-bunyan#300.
I'm not expecting this to be merged at the moment -- without the upstream bunyan PR, it doesn't make a lot of sense -- but I needed this functionality now, so I'm putting it out there for a review. If bunyanmerges my PR, what would need to change here to get this merged?
Thanks.