Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

joyent/node-sshpk#32 broke node <5.x by using Buffer.from #35

Closed
arekinath opened this issue Aug 19, 2017 · 0 comments
Closed

joyent/node-sshpk#32 broke node <5.x by using Buffer.from #35

arekinath opened this issue Aug 19, 2017 · 0 comments

Comments

@arekinath
Copy link

The DNSSEC support work uses Buffer.from, which is only available in node after 5.x. We can't use that in sshpk, which still needs to work back to 0.10.
joyent-automation pushed a commit that referenced this issue Aug 19, 2017
#35 #32 broke node <5.x by using Buffer.from
760b71c 
Reviewed by: Tim Kordas <tim.kordas@joyent.com>
This was referenced Oct 10, 2018
Merged
Merged
@dependabot-preview dependabot-preview bot mentioned this issue Dec 30, 2018
Closed
This was referenced Apr 12, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced May 31, 2019
Merged
Open
Closed
Merged
@dependabot dependabot bot mentioned this issue Jul 12, 2019
Merged
@dependabot-preview dependabot-preview bot mentioned this issue Jul 19, 2019
Closed
@dependabot dependabot bot mentioned this issue Aug 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@arekinath