Skip to content

Commit

Permalink
test: remove flaky designation for test_threadsafe_function
Browse files Browse the repository at this point in the history
The test_threadsafe_function doesn't seem to be flaky anymore on
Windows. Optimistically removing the flaky designation in the relevant
status file.

Refs: nodejs#23621 (comment)

PR-URL: nodejs#26403
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
  • Loading branch information
Trott committed Mar 4, 2019
1 parent 20c2ca8 commit 33880d7
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions test/node-api/node-api.status
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,3 @@ prefix node-api
[true] # This section applies to all platforms

[$system==win32]
# https://github.com/nodejs/node/issues/23621
test_threadsafe_function/test: PASS,FLAKY

0 comments on commit 33880d7

Please sign in to comment.